Re: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings

[Krzysztof Kozlowski]

On 15/11/2023 09:38, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
>> -----Original Message-----
>> From: Conor Dooley <conor@xxxxxxxxxx>
>> Sent: Friday, November 10, 2023 1:10 AM
>> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx>
>> Cc: patrick@xxxxxxxxx; Jean Delvare <jdelvare@xxxxxxxx>; Guenter Roeck
>> <linux@xxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
>> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
>> Jonathan Corbet <corbet@xxxxxxx>; linux-i2c@xxxxxxxxxxxxxxx;
>> linux-hwmon@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
>> linux-kernel@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx
>> Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver
>> bindings
>>
>> On Thu, Nov 09, 2023 at 09:49:45AM +0800, Delphine CC Chiu wrote:
>>> Add a device tree bindings for ltc4286 device.
>>>
>>> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>
>>>
>>> Changelog:
>>>   v4 - Revise some inappropriate writing in yaml file
>>>   v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable
>>>   v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6
>>>      - Add type for adi,vrange-select-25p6
>>>      - Revise rsense-micro-ohms to shunt-resistor-micro-ohms
>>
>> Your changelog should be below the --- line.
> 
> We will add --- line on our changelog.
> 
>> You also omitted the tag I left on the previous version.
> 
> Could you point out the exact places that we omit?

Open the previous email and read it fully. Did you or did you not get a tag?

> Thanks.
> 
>> With the changelog fixed:
>> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
Best regards,
Krzysztof