Re: [PATCH v3 04/25] i2c: designware: Let PCI core to take care about interrupt vectors

[Jarkko Nikula]

On 11/10/23 20:11, Andy Shevchenko wrote:
> PCI core, after pcim_enable_device(), takes care about the allocated
> IRQ vectors, no need to do it explicitly and break the cleaning up
> order.
>
> Fixes: 21aa3983d619 ("i2c: designware-pci: Switch over to MSI interrupts")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>   drivers/i2c/busses/i2c-designware-pcidrv.c | 15 +++------------
>   1 file changed, 3 insertions(+), 12 deletions(-)

...

> @@ -360,9 +354,6 @@ static void i2c_dw_pci_remove(struct pci_dev *pdev)
>   
>   	pm_runtime_forbid(&pdev->dev);
>   	pm_runtime_get_noresume(&pdev->dev);
> -
> -	devm_free_irq(&pdev->dev, dev->irq, dev);
> -	pci_free_irq_vectors(pdev);

Instead of commit 21aa3983d619 I guess this patch is more around my 
commit 9be8bc4dd617 ("i2c: designware-pci: Fix BUG_ON during device 
removal")? But still I don't think it qualifies Fixes tag?

I was curious to see would this patch bring back above BUG_ON and 
fortunately not (rmmod/modprobe i2c_designware_pci on MSI enabled 
instance):-)

Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>