Re: [PATCH] arm64: dts: mt8173: Add G2Touch touchscreen node

[Chen-Yu Tsai]

On Tue, Nov 14, 2023 at 6:44 PM Pin-yen Lin <treapking@xxxxxxxxxxxx> wrote:
>
> Lenovo Ideapad C330 Chromebook (MTK) uses G2Touch touchscreen as a
> second source component.
>
> Signed-off-by: Pin-yen Lin <treapking@xxxxxxxxxxxx>
> ---
>
>  arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
> index bdcd35cecad9..0d6dbc36c352 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
> @@ -29,6 +29,14 @@ touchscreen3: touchscreen@20 {
>                 interrupt-parent = <&pio>;
>                 interrupts = <88 IRQ_TYPE_LEVEL_LOW>;
>         };
> +
> +       touchscreen4: touchscreen@40 {

The label likely isn't needed.

Otherwise,

Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>

> +               compatible = "hid-over-i2c";
> +               reg = <0x40>;
> +               hid-descr-addr = <0x0001>;
> +               interrupt-parent = <&pio>;
> +               interrupts = <88 IRQ_TYPE_LEVEL_LOW>;
> +       };
>  };
>
>  &i2c4 {
> --
> 2.42.0.869.gea05f2083d-goog
>