Re: [PATCH] autofs: fix null deref in autofs_fill_super

From: Ian Kent
Date: Tue Nov 14 2023 - 20:06:59 EST


On 15/11/23 08:35, Al Viro wrote:
On Wed, Nov 15, 2023 at 08:18:33AM +0800, Ian Kent wrote:

I guess that including the locking is not going to make much difference.

I don't remember now but it was probably done because there may be many

mounts (potentially several thousand) being done and I wanted to get rid

of anything that wasn't needed.
Seeing that lock in question is not going to be contended... ;-)

Seriously, though - the fewer complications we have in the locking rules,
the better.

Sure, no problem, I'll make that change.

I do need to do a compile and test it actually ok works so it's

taking a little while.


Ian


Al, currently going through audit of ->d_name/->d_parent uses and cursing
at the 600-odd places left to look through...