Re: [PATCH 12/36] sched_ext: Implement BPF extensible scheduler class

From: Tejun Heo
Date: Tue Nov 14 2023 - 14:07:38 EST


On Mon, Nov 13, 2023 at 03:04:24PM -0500, Andrea Righi wrote:
> > +#ifdef CONFIG_SCHED_DEBUG
> > +static const char *scx_ops_enable_state_str[] = {
> > + [SCX_OPS_PREPPING] = "prepping",
> > + [SCX_OPS_ENABLING] = "enabling",
> > + [SCX_OPS_ENABLED] = "enabled",
> > + [SCX_OPS_DISABLING] = "disabling",
> > + [SCX_OPS_DISABLED] = "disabled",
> > +};
>
> We may want to move scx_ops_enable_state_str[] outside of
> CONFIG_SCHED_DEBUG, because we're using it later in print_scx_info()
> ("sched_ext: Print sched_ext info when dumping stack"), or we make
> print_scx_info() dependent of CONFIG_SCHED_DEBUG.

Yeah, Changwoo noticed the same problem. Will fix and post an updated patch.

Thanks.

--
tejun