Re: [PATCH v2 1/1] lib/vsprintf: Fix %pfwf when current node refcount == 0

From: Herve Codina
Date: Tue Nov 14 2023 - 10:13:49 EST


Hi Andy,

On Tue, 14 Nov 2023 16:59:35 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

[...]

>
> One nit-pick below, otherwise
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> ...
>
> > /* Loop starting from the root node to the current node. */
> > for (depth = fwnode_count_parents(fwnode); depth >= 0; depth--) {
> > - struct fwnode_handle *__fwnode =
> > - fwnode_get_nth_parent(fwnode, depth);
> > + /*
> > + * Only get a reference for other nodes (ie parents node).
>
> "parent's node" (doesn't look right)? Or "parent nodes"?
>

Will be changed to "parent nodes" in the next iteration.

Best regards,
Hervé