Re: [PATCH v4 2/5] x86/alternative: add indirect call patching

From: Borislav Petkov
Date: Tue Nov 14 2023 - 08:47:39 EST


On Tue, Nov 14, 2023 at 01:50:28PM +0100, Peter Zijlstra wrote:
> This loads the function target from the pv_ops table. We can't otherwise
> do this.

On Tue, Nov 14, 2023 at 01:56:37PM +0100, Juergen Gross wrote:
> It is replacing an _indirect_ call with a _direct_ one, taking the
> call target from the pointer used by the indirect call.

Then this is not just a ALT_FLAG_CALL. This is something special. The
flag definition needs a better name along with an explanation what it
does, perhaps best with an example from the final vmlinux - not from the
object file:

call *0x0(%rip)

==>

call *0x0

where the offsets haven't been linked in yet.

If this is going into the generic infrastructure, then it better be
explained properly so that other stuff can potentially use it too.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette