Re: [PATCH] pinctrl: s32cc: Avoid possible string truncation

[Linus Walleij]

On Tue, Nov 7, 2023 at 3:10 PM Chester Lin <clin@xxxxxxxx> wrote:

> With "W=1" and "-Wformat-truncation" build options, the kernel test robot
> found a possible string truncation warning in pinctrl-s32cc.c, which uses
> an 8-byte char array to hold a memory region name "map%u". Since the
> maximum number of digits that a u32 value can present is 10, and the "map"
> string occupies 3 bytes with a termination '\0', which means the rest 4
> bytes cannot fully present the integer "X" that exceeds 4 digits.
>
> Here we check if the number >= 10000, which is the lowest value that
> contains more than 4 digits.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311030159.iyUGjNGF-lkp@xxxxxxxxx/
> Signed-off-by: Chester Lin <clin@xxxxxxxx>

Thanks for fixing this!
Patch applied for fixes.

Yours,
Linus Walleij