Re: drivers/pinctrl/cirrus/pinctrl-lochnagar.c:52:53: error: pasting "LOCHNAGAR1_" and "(" does not give a valid preprocessing token

From: Linus Walleij
Date: Tue Nov 14 2023 - 08:40:54 EST


On Tue, Nov 7, 2023 at 6:19 AM kernel test robot <lkp@xxxxxxxxx> wrote:

> >> drivers/pinctrl/cirrus/pinctrl-lochnagar.c:52:53: error: pasting "LOCHNAGAR1_" and "(" does not give a valid preprocessing token
> 52 | .name = NAME, .type = LN_PTYPE_GPIO, .reg = LOCHNAGAR##REV##_##REG, \
> | ^~~~~~~~~
> drivers/pinctrl/cirrus/pinctrl-lochnagar.c:67:9: note: in expansion of macro 'LN_PIN_GPIO'
> 67 | LN_PIN_GPIO(1, ID, NAME, REG, SHIFT, INVERT)
> | ^~~~~~~~~~~

I looked a bit at this, can this be due to the fact that the macros use defines
from include/dt-bindings/...* and that MIPS does not use these includes
somehow, such as not using the same dtc compiler?

Rob, do you know the story of how MIPS interoperates with <dt-bindings/*>?

Yours,
Linus Walleij