Re: [PATCH] pinctrl: avoid reload of p state in interation

From: Linus Walleij
Date: Tue Nov 14 2023 - 08:21:57 EST


Hi Maria,

thanks for your patch!

On Tue, Nov 14, 2023 at 9:54 AM Maria Yu <quic_aiquny@xxxxxxxxxxx> wrote:

> When in the list_for_each_entry interation, reload of p->state->settings
> with a local setting from old_state will makes the list interation in a
> infite loop.
>
> Signed-off-by: Maria Yu <quic_aiquny@xxxxxxxxxxx>

This makes sense in a way, since this is a compiler-dependent problem,
can you state in the commit message which compiler and architecture
you see this on?

If it is a regression, should this also be queued for stable? (I guess so?)

Yours,
Linus Walleij