Re: [PATCH 3/3] x86/apic: Drop struct local_apic

From: Ilpo Järvinen
Date: Tue Nov 14 2023 - 06:41:47 EST


On Fri, 3 Nov 2023, Steve Wahl wrote:

> On Thu, Nov 02, 2023 at 12:26:21PM +0000, Andrew Cooper wrote:
> > This type predates recorded history in tglx/history.git, making it older
> > than Feb 5th 2002.
> >
> > This structure is literally old enough to drink in most juristictions in
> > the world, and has not been used once in that time.
> >
> > Lay it to rest in /dev/null.
> >
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > ---
> > There is perhaps something to be said for the longevity of the comment.
> > "Not terribly well tested" certainly hasn't bitrotted in all this time.
>
> :-) !!!
>
> Reveiewed-by: Steve Wahl <steve.wahl@xxxxxxx>

There's a typo in your tag (and it was copy-pasted to all patches of this
series).

--
i.