RE: [PATCH v2] usb: dwc3: add missing of_node_put and platform_device_put

From: Stanley Chang[昌育德]
Date: Tue Nov 14 2023 - 06:12:24 EST


Hi Sergey,

> On 11/14/23 1:16 PM, Stanley Chang wrote:
>
> > of_get_compatible_child performs an of_node_get, so an of_node_get is
>
> You mean of_node_put is required?

Right, it is of_node_put.
I'm sorry for the typo.

Thanks,
Stanley

> > required. Add platform_device_put to match with of_find_device_by_node.
> >
> > Fixes: 34c200483569 ("usb: dwc3: add Realtek DHC RTD SoC dwc3 glue layer
> driver")
> > Signed-off-by: Stanley Chang <stanley_chang@xxxxxxxxxxx>
> > Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
> > ---
> > v1 to v2 change:
> > 1. Modify the commit message.
> > 2. Add of_node_get in the of_property_read_string() error path.
> [...]
>
> MBR, Sergey