Re: [PATCH v4 2/2] tg3: Increment tx_dropped in tg3_tso_bug()
From: Pavan Chebbi
Date: Tue Nov 14 2023 - 05:06:42 EST
On Mon, Nov 13, 2023 at 11:54 PM <alexey.pakhunov@xxxxxxxxxx> wrote:
>
> From: Alex Pakhunov <alexey.pakhunov@xxxxxxxxxx>
>
> tg3_tso_bug() drops a packet if it cannot be segmented for any reason.
> The number of discarded frames should be incremented accordingly.
>
> Signed-off-by: Alex Pakhunov <alexey.pakhunov@xxxxxxxxxx>
> Signed-off-by: Vincent Wong <vincent.wong2@xxxxxxxxxx>
> ---
> drivers/net/ethernet/broadcom/tg3.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index dcaf97198ac2..8f22b4cdc31f 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -7874,8 +7874,10 @@ static int tg3_tso_bug(struct tg3 *tp, struct tg3_napi *tnapi,
>
> segs = skb_gso_segment(skb, tp->dev->features &
> ~(NETIF_F_TSO | NETIF_F_TSO6));
> - if (IS_ERR(segs) || !segs)
> + if (IS_ERR(segs) || !segs) {
> + tnapi->tx_dropped++;
> goto tg3_tso_bug_end;
> + }
>
> skb_list_walk_safe(segs, seg, next) {
> skb_mark_not_on_list(seg);
> --
> 2.39.3
>
>
Reviewed-by: Pavan Chebbi <pavan.chebbi@xxxxxxxxxxxx>
Thank you.
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature