Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Tue, Nov 14, 2023 at 3:13 AM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:

> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:232:10: error: 'const struct lpi_pinctrl_variant_data' has no member named 'flags'
>   232 |         .flags = LPI_FLAG_SLEW_RATE_SAME_REG,
>       |          ^~~~~
> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:232:18: error: 'LPI_FLAG_SLEW_RATE_SAME_REG' undeclared here (not in a function); did you mean 'LPI_SLEW_RATE_CTL_REG'?
>   232 |         .flags = LPI_FLAG_SLEW_RATE_SAME_REG,
>       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                  LPI_SLEW_RATE_CTL_REG
> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:232:18: error: excess elements in struct initializer [-Werror]
> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:232:18: note: (near initialization for 'sm8650_lpi_data')
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   c4e47673853f ("pinctrl: qcom: sm8650-lpass-lpi: add SM8650 LPASS")

Ah I forgot a prerequisite patch we postponed before.

Applied it now so things should work by tomorrow, thanks!

Yours,
Linus Walleij