Re: [PATCH] pwm: bcm2835: Fix NPD in suspend/resume

From: Uwe Kleine-König
Date: Mon Nov 13 2023 - 15:53:28 EST


Hello,

On Mon, Nov 13, 2023 at 08:46:32AM -0800, Florian Fainelli wrote:
> When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was
> sent out on October 11th,, there was still a call to
> platform_set_drvdata() which would ensure that the driver private data
> structure could be used in bcm2835_pwm_{suspend,resume}.
>
> A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835:
> Simplify using devm functions") removed that call which would now cause
> a NPD in bcm2835_pwm_{suspend,resume} as a consequence.
>
> Fixes: 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume")
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>

oops, indeed.

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature