Re: [PATCH] cifs: fix check of rc in function generate_smb3signingkey

From: Paulo Alcantara
Date: Mon Nov 13 2023 - 13:49:52 EST


Ekaterina Esina <eesina@xxxxxxxxxxxxx> writes:

> Remove extra check after condition, add check after generating key
> for encryption. The check is needed to return non zero rc before
> rewriting it with generating key for decryption.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: d70e9fa55884 ("cifs: try opening channels after mounting")
> Signed-off-by: Ekaterina Esina <eesina@xxxxxxxxxxxxx>
> Co-developed-by: Anastasia Belova <abelova@xxxxxxxxxxxxx>
> Signed-off-by: Anastasia Belova <abelova@xxxxxxxxxxxxx>
> ---
> fs/smb/client/smb2transport.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Paulo Alcantara (SUSE) <pc@xxxxxxxxxxxxx>