Re: [PATCH] intel_idle: add CPUIDLE_FLAG_IRQ_ENABLE to SPR C1 and C1E

From: Jon Kohler
Date: Mon Nov 13 2023 - 10:21:13 EST




> On Nov 12, 2023, at 6:52 AM, Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx> wrote:
>
> On Fri, 2023-11-10 at 20:00 +0000, Jon Kohler wrote:
>> CPUIDLE_FLAG_IRQ_ENABLE
>
> Hi, yes, I did run several experiments, and found that this change would make
> some micro benchmarks give worse score. I did a lot of repetitions assuming I
> was mixing noise with signal, but every time confirmed that enabling interrupts
> in C1 made the score worse (like 1%).
>
> I do not have explanation for this phenomena, but decided to not pursue this
> idea.
>
> Artem.

Thanks for the follow up. Indeed that is strange on why it would make it worse, but it
is good to know that the shipping configuration is going to work out best.

Thanks,
Jon