RE: [PATCH net,v4, 2/3] hv_netvsc: Fix race of register_netdevice_notifier and VF register

From: Dexuan Cui
Date: Sun Nov 12 2023 - 21:56:07 EST


> From: LKML haiyangz <lkmlhyz@xxxxxxxxxxxxx> On Behalf Of Haiyang Zhang
> Sent: Friday, November 10, 2023 9:39 AM
> [...]
> If VF NIC is registered earlier, NETDEV_REGISTER event is replayed,
> but NETDEV_POST_INIT is not.
>
> Move register_netdevice_notifier() earlier, so the call back
> function is set before probing.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: e04e7a7bbd4b ("hv_netvsc: Fix a deadlock by getting rtnl lock earlier in
> netvsc_probe()")
> Reported-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
> Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@xxxxxxxxx>

Reviewed-by: Dexuan Cui <decui@xxxxxxxxxxxxx>

It's better to post a new version that follows Simon Horman's suggestion,
i.e., use a more idiomatic form for the error path.