Re: [RFC v6 0/8] DRM scheduling cgroup controller

From: Tejun Heo
Date: Sun Nov 12 2023 - 15:38:23 EST


Hello,

>From cgroup POV, it generally looks fine to me. As before, I'm really
curious whether this is something other non-intel drivers can get behind.
Just one nit.

On Tue, Oct 24, 2023 at 05:07:19PM +0100, Tvrtko Ursulin wrote:
> * Allowing per DRM card configuration and queries is deliberatly left out but
> it is compatible in principle with the current proposal.
>
> Where today we have, for drm.weight:
>
> 100
>
> We can later extend with:
>
> 100
> card0 80
> card1 20
>
> Similarly for drm.stat:
>
> usage_usec 1000
> card0.usage_usec 500
> card1.usage_usec 500

These dont't match what blkcg is doing. Please use nested keyed format
instead.

Thanks.

--
tejun