drivers/cpuidle/governors/ladder.c:54: warning: Function parameter or member 'dev' not described in 'ladder_do_selection'

From: kernel test robot
Date: Sat Nov 11 2023 - 22:15:39 EST


Hi Marcelo,

FYI, the error/warning still remains.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3ca112b71f35dd5d99fc4571a56b5fc6f0c15814
commit: 7d4daeedd575bbc3c40c87fc6708a8b88c50fe7e governors: unify last_state_idx
date: 4 years, 3 months ago
config: x86_64-alldefconfig (https://download.01.org/0day-ci/archive/20231112/202311121013.hcdaCtXP-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231112/202311121013.hcdaCtXP-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311121013.hcdaCtXP-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/cpuidle/governors/ladder.c:54: warning: Function parameter or member 'dev' not described in 'ladder_do_selection'


vim +54 drivers/cpuidle/governors/ladder.c

4f86d3a8e29720 Len Brown 2007-10-03 44
4f86d3a8e29720 Len Brown 2007-10-03 45 /**
4f86d3a8e29720 Len Brown 2007-10-03 46 * ladder_do_selection - prepares private data for a state change
4f86d3a8e29720 Len Brown 2007-10-03 47 * @ldev: the ladder device
4f86d3a8e29720 Len Brown 2007-10-03 48 * @old_idx: the current state index
4f86d3a8e29720 Len Brown 2007-10-03 49 * @new_idx: the new target state index
4f86d3a8e29720 Len Brown 2007-10-03 50 */
7d4daeedd575bb Marcelo Tosatti 2019-07-03 51 static inline void ladder_do_selection(struct cpuidle_device *dev,
7d4daeedd575bb Marcelo Tosatti 2019-07-03 52 struct ladder_device *ldev,
4f86d3a8e29720 Len Brown 2007-10-03 53 int old_idx, int new_idx)
4f86d3a8e29720 Len Brown 2007-10-03 @54 {
4f86d3a8e29720 Len Brown 2007-10-03 55 ldev->states[old_idx].stats.promotion_count = 0;
4f86d3a8e29720 Len Brown 2007-10-03 56 ldev->states[old_idx].stats.demotion_count = 0;
7d4daeedd575bb Marcelo Tosatti 2019-07-03 57 dev->last_state_idx = new_idx;
4f86d3a8e29720 Len Brown 2007-10-03 58 }
4f86d3a8e29720 Len Brown 2007-10-03 59

:::::: The code at line 54 was first introduced by commit
:::::: 4f86d3a8e297205780cca027e974fd5f81064780 cpuidle: consolidate 2.6.22 cpuidle branch into one patch

:::::: TO: Len Brown <len.brown@xxxxxxxxx>
:::::: CC: Len Brown <len.brown@xxxxxxxxx>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki