RE: [PATCH 17/17] arm64: dts: exynosautov9: add specific compatibles to several blocks

From: Alim Akhtar
Date: Fri Nov 10 2023 - 20:46:04 EST




> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ExynosAutov9 reuses several devices from older designs, thus historically we
> kept the old (block's) compatible only. This works fine and there is no bug
> here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
>
> Add compatibles specific to ExynosAutov9 in front of all old-SoC-like
> compatibles. This will also help reviews of new code using existing DTS as
> template. No functional impact on Linux drivers behavior.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
(...)