RE: [PATCH 07/17] dt-bindings: serial: samsung: add specific compatibles for existing SoC

From: Alim Akhtar
Date: Fri Nov 10 2023 - 20:06:03 EST




> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Wednesday, November 8, 2023 4:14 PM
> Samsung Exynos SoC reuses several devices from older designs, thus
> historically we kept the old (block's) compatible only. This works fine and
> there is no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
>
> Add compatibles specific to each SoC in front of all old-SoC-like compatibles.
>
> Re-shuffle also the entries in compatibles, so the one-compatible-enum is
> the first.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> ---
>
> I propose to take the patch through Samsung SoC (me). See cover letter for
> explanation.
> ---
> .../devicetree/bindings/serial/samsung_uart.yaml | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
(...)