Re: [PATCH] mm/damon/core.c: avoid unintentional filtering out of schemes

[Hyeongtak Ji]

On Sat, Nov 11, 2023 at 3:31 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri, 10 Nov 2023 18:22:40 +0000 SeongJae Park <sj@xxxxxxxxxx> wrote:
>
> > Hello Hyueongtak,
> >
> > On Fri, 10 Nov 2023 14:37:09 +0900 Hyeongtak Ji <hyeongtak.ji@xxxxxxxxx> wrote:
> >
> > > The function '__damos_filter_out()' causes DAMON to always filter out
> > > schemes whose filter type is anon or memcg if its matching value is set
> > > to false.
> > >
> > > This commit addresses the issue by ensuring that '__damos_filter_out()'
> > > no longer applies to filters whose type is 'anon' or 'memcg'.
> >
> > Nice catch, thank you!
> >
> > checkpatch.pl shows one warning, though:
> >
> >     WARNING: From:/Signed-off-by: email address mismatch: 'From: Hyeongtak Ji <hyeongtak.ji@xxxxxxxxx>' != 'Signed-off-by: Hyeongtak Ji <hyeongtak.ji@xxxxxx>'
>
> This can be addressed by including an explicit From: line at start of
> changelog.  Which should we use?

Please use <hyeongtak.ji@xxxxxx> if it's possible.

>
> > >
> > > Signed-off-by: Hyeongtak Ji <hyeongtak.ji@xxxxxx>
> >
> > Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>
>
> I'll add
>
> Fixes: ab9bda001b681 ("mm/damon/core: introduce address range type damos filter")
> Cc: <stable@xxxxxxxxxxxxxxx>
>