Re: [PATCH v7 2/2] rtc: max31335: add driver support
From: kernel test robot
Date: Fri Nov 10 2023 - 16:29:57 EST
Hi Antoniu,
kernel test robot noticed the following build warnings:
[auto build test WARNING on abelloni/rtc-next]
[also build test WARNING on linus/master v6.6 next-20231110]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Antoniu-Miclaus/rtc-max31335-add-driver-support/20231109-231755
base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link: https://lore.kernel.org/r/20231109101449.8347-2-antoniu.miclaus%40analog.com
patch subject: [PATCH v7 2/2] rtc: max31335: add driver support
config: x86_64-randconfig-123-20231111 (https://download.01.org/0day-ci/archive/20231111/202311110508.MdqXcQsW-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231111/202311110508.MdqXcQsW-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311110508.MdqXcQsW-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
>> drivers/rtc/rtc-max31335.c:504:22: sparse: sparse: symbol 'max31335_clk_init' was not declared. Should it be static?
>> drivers/rtc/rtc-max31335.c:527:21: sparse: sparse: symbol 'max31335_nvmem_cfg' was not declared. Should it be static?
vim +/max31335_clk_init +504 drivers/rtc/rtc-max31335.c
503
> 504 struct clk_init_data max31335_clk_init = {
505 .name = "max31335-clkout",
506 .ops = &max31335_clkout_ops,
507 };
508
509 static int max31335_nvmem_reg_read(void *priv, unsigned int offset,
510 void *val, size_t bytes)
511 {
512 struct max31335_data *max31335 = priv;
513 unsigned int reg = MAX31335_TS0_SEC_1_128 + offset;
514
515 return regmap_bulk_read(max31335->regmap, reg, val, bytes);
516 }
517
518 static int max31335_nvmem_reg_write(void *priv, unsigned int offset,
519 void *val, size_t bytes)
520 {
521 struct max31335_data *max31335 = priv;
522 unsigned int reg = MAX31335_TS0_SEC_1_128 + offset;
523
524 return regmap_bulk_write(max31335->regmap, reg, val, bytes);
525 }
526
> 527 struct nvmem_config max31335_nvmem_cfg = {
528 .reg_read = max31335_nvmem_reg_read,
529 .reg_write = max31335_nvmem_reg_write,
530 .word_size = 8,
531 .size = MAX31335_RAM_SIZE,
532 };
533
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki