Re: [PATCH 02/17] dt-bindings: i2c: exynos5: add specific compatibles for existing SoC

From: Rob Herring
Date: Fri Nov 10 2023 - 15:38:27 EST



On Wed, 08 Nov 2023 11:43:28 +0100, Krzysztof Kozlowski wrote:
> Samsung Exynos SoC reuses several devices from older designs, thus
> historically we kept the old (block's) compatible only. This works fine
> and there is no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
>
> Add compatibles specific to each SoC in front of all old-SoC-like
> compatibles.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> I propose to take the patch through Samsung SoC (me). See cover letter
> for explanation.
> ---
> Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml | 10 +++++++++-
> .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 2 +-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>

Acked-by: Rob Herring <robh@xxxxxxxxxx>