Re: [PATCH] Revert "i2c: pxa: move to generic GPIO recovery"

From: Russell King (Oracle)
Date: Fri Nov 10 2023 - 13:11:34 EST


On Fri, Nov 10, 2023 at 10:30:11AM +0100, Robert Marko wrote:
> This reverts commit 0b01392c18b9993a584f36ace1d61118772ad0ca.
>
> Conversion of PXA to generic I2C recovery, makes the I2C bus completely
> lock up if recovery pinctrl is present in the DT and I2C recovery is
> enabled.
>
> So, until the generic I2C recovery can also work with PXA lets revert
> to have working I2C and I2C recovery again.
>
> Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # 5.11+

My feels were that this should not have been converted to the generic
recovery as pointed out at the time, so thanks for confirming that it
broke as a result of that conversion, it did indeed break.

Acked-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>

Thanks!

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!