Re: [PATCH v8 04/12] dt-bindings: phy: amlogic,g12a-mipi-dphy-analog: drop unneeded reg property and example

[Neil Armstrong]

On 09/11/2023 19:04, Conor Dooley wrote:
> On Thu, Nov 09, 2023 at 10:00:05AM +0100, Neil Armstrong wrote:
> > Now this bindings is referred from amlogic,meson-gx-hhi-sysctrl.yaml and is
> > documented as a subnode of a simple-mfd, drop the invalid reg property.
>
> I'd expect a note here tbh about how removing reg & relying on being a
> subnode of the simple-mfd is safe to do. It looks like your driver
> was added at the same time as this binding & it was always documented as
> being a child of the simple-mfd system controller, so I'd kinda expect
> to see a Fixes tag on this patch..
>
> Am I missing something?

No you're totally right, I'll reword the commit message and add a Fixes tags.

Thanks,
Neil

> > Also drop the unnecessary example, the top level bindings example should
> > be enough.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   .../bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml          | 12 ------------
> >   1 file changed, 12 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml
> > index c8c83acfb871..81c2654b7e57 100644
> > --- a/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml
> > +++ b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml
> > @@ -16,20 +16,8 @@ properties:
> >     "#phy-cells":
> >       const: 0
> >   
> > -  reg:
> > -    maxItems: 1
> > -
> >   required:
> >     - compatible
> > -  - reg
> >     - "#phy-cells"
> >   
> >   additionalProperties: false
> > -
> > -examples:
> > -  - |
> > -    phy@0 {
> > -          compatible = "amlogic,g12a-mipi-dphy-analog";
> > -          reg = <0x0 0xc>;
> > -          #phy-cells = <0>;
> > -    };
> >
> > --
> > 2.34.1