Re: [PATCH v2 11/12] i2c: designware: Remove ->disable() callback

From: kernel test robot
Date: Thu Nov 09 2023 - 17:38:50 EST


Hi Andy,

kernel test robot noticed the following build errors:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on linus/master v6.6 next-20231109]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/i2c-designware-Replace-MODULE_ALIAS-with-MODULE_DEVICE_TABLE/20231110-040556
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
patch link: https://lore.kernel.org/r/20231109182823.3531846-12-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v2 11/12] i2c: designware: Remove ->disable() callback
config: arc-randconfig-002-20231110 (https://download.01.org/0day-ci/archive/20231110/202311100640.B5B7MhDJ-lkp@xxxxxxxxx/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231110/202311100640.B5B7MhDJ-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311100640.B5B7MhDJ-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

drivers/i2c/busses/i2c-designware-slave.c: In function 'i2c_dw_unreg_slave':
>> drivers/i2c/busses/i2c-designware-slave.c:95:12: error: 'struct dw_i2c_dev' has no member named 'disable'
95 | dev->disable(dev);
| ^~


vim +95 drivers/i2c/busses/i2c-designware-slave.c

9f3e065c54b05b Luis Oliveira 2017-06-22 89
9f3e065c54b05b Luis Oliveira 2017-06-22 90 static int i2c_dw_unreg_slave(struct i2c_client *slave)
9f3e065c54b05b Luis Oliveira 2017-06-22 91 {
9f3e065c54b05b Luis Oliveira 2017-06-22 92 struct dw_i2c_dev *dev = i2c_get_adapdata(slave->adapter);
9f3e065c54b05b Luis Oliveira 2017-06-22 93
fee61247b7f67a Jarkko Nikula 2022-11-07 94 regmap_write(dev->map, DW_IC_INTR_MASK, 0);
9f3e065c54b05b Luis Oliveira 2017-06-22 @95 dev->disable(dev);
c486dcd2f1bbdd Jarkko Nikula 2019-08-15 96 synchronize_irq(dev->irq);
9f3e065c54b05b Luis Oliveira 2017-06-22 97 dev->slave = NULL;
2a86cdd2e7d3c7 Jarkko Nikula 2017-08-15 98 pm_runtime_put(dev->dev);
9f3e065c54b05b Luis Oliveira 2017-06-22 99
9f3e065c54b05b Luis Oliveira 2017-06-22 100 return 0;
9f3e065c54b05b Luis Oliveira 2017-06-22 101 }
9f3e065c54b05b Luis Oliveira 2017-06-22 102

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki