Re: [v4 1/3] mm/rmap: Recognize read-only TLB entries during batched TLB flush

From: kernel test robot
Date: Thu Nov 09 2023 - 15:27:28 EST


Hi Byungchul,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on tip/x86/core tip/x86/mm linus/master v6.6 next-20231109]
[cannot apply to akpm-mm/mm-everything]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Byungchul-Park/mm-rmap-Recognize-read-only-TLB-entries-during-batched-TLB-flush/20231109-163706
base: tip/sched/core
patch link: https://lore.kernel.org/r/20231109045908.54996-2-byungchul%40sk.com
patch subject: [v4 1/3] mm/rmap: Recognize read-only TLB entries during batched TLB flush
config: arm64-randconfig-002-20231109 (https://download.01.org/0day-ci/archive/20231110/202311100429.nc4jJoNu-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231110/202311100429.nc4jJoNu-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311100429.nc4jJoNu-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

mm/rmap.c: In function 'fold_ubc_ro':
>> mm/rmap.c:620:9: error: implicit declaration of function 'arch_tlbbatch_fold'; did you mean 'arch_tlbbatch_flush'? [-Werror=implicit-function-declaration]
620 | arch_tlbbatch_fold(&tlb_ubc->arch, &tlb_ubc_ro->arch);
| ^~~~~~~~~~~~~~~~~~
| arch_tlbbatch_flush
>> mm/rmap.c:626:9: error: implicit declaration of function 'arch_tlbbatch_clear'; did you mean 'arch_tlbbatch_flush'? [-Werror=implicit-function-declaration]
626 | arch_tlbbatch_clear(&tlb_ubc_ro->arch);
| ^~~~~~~~~~~~~~~~~~~
| arch_tlbbatch_flush
cc1: some warnings being treated as errors


vim +620 mm/rmap.c

608
609 void fold_ubc_ro(void)
610 {
611 struct tlbflush_unmap_batch *tlb_ubc = &current->tlb_ubc;
612 struct tlbflush_unmap_batch *tlb_ubc_ro = &current->tlb_ubc_ro;
613
614 if (!tlb_ubc_ro->flush_required)
615 return;
616
617 /*
618 * Fold tlb_ubc_ro's data to tlb_ubc.
619 */
> 620 arch_tlbbatch_fold(&tlb_ubc->arch, &tlb_ubc_ro->arch);
621 tlb_ubc->flush_required = true;
622
623 /*
624 * Reset tlb_ubc_ro's data.
625 */
> 626 arch_tlbbatch_clear(&tlb_ubc_ro->arch);
627 tlb_ubc_ro->flush_required = false;
628 }
629

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki