Re: [PATCH V5 2/8] perf/x86: Add PERF_X86_EVENT_NEEDS_BRANCH_STACK flag

[Arnaldo Carvalho de Melo]

Em Thu, Nov 09, 2023 at 12:05:27PM -0500, Liang, Kan escreveu:
> On 2023-11-09 11:45 a.m., Arnaldo Carvalho de Melo wrote:
> > Em Thu, Nov 09, 2023 at 11:14:31AM -0500, Liang, Kan escreveu:
> >> The below change should fix it. I will post a complete patch shortly.

> > Thanks for the quick response, if all that is needed are the checks
> > below, I'll fold it into your original patch:

> > 2ae01908298426e4 perf tools: Add branch counter knob

> > So that we don't regress, ok?

> Sure.

> I also post the patch to
> https://lore.kernel.org/lkml/20231109164007.2037721-1-kan.liang@xxxxxxxxxxxxxxx/
> Either folding it or using the new patch is fine for me.

I folded it, retested, pushed out perf-tools-next.
 
> BTW: the new perf test case for the feature is posted here.
> I think Ian is reviewing it.
> https://lore.kernel.org/lkml/20231107184020.1497571-1-kan.liang@xxxxxxxxxxxxxxx/

Ok, lets wait some more.

Hey, what is SFR/GRR? Sapphire Rapids/Granite Rapids? I thought about
testing this somehow, if possible.

- Arnaldo