Re: [PATCH] debugfs: only clean up d_fsdata for d_is_reg()

From: Johannes Berg
Date: Thu Nov 09 2023 - 13:40:30 EST


On Thu, 2023-11-09 at 16:06 +0100, Johannes Berg wrote:
>
> @@ -734,6 +725,11 @@ static void __debugfs_file_removed(struct dentry *dentry)
> return;
> if (!refcount_dec_and_test(&fsd->active_users))
> wait_for_completion(&fsd->active_users_drained);
> +
> + /* this no longer matters */
> + dentry->d_fsdata = NULL;
>

That's not true, and therefore this patch is wrong -
full_proxy_release() still happens later.

Not sure why I didn't see that originally, even in tests.

I'll try again :)

johannes