Re: [PATCH v7 05/24] x86/resctrl: Track the closid with the rmid

From: Reinette Chatre
Date: Thu Nov 09 2023 - 12:41:38 EST


Hi James,

On 10/25/2023 11:03 AM, James Morse wrote:
> @@ -732,10 +752,10 @@ static int dom_data_init(struct rdt_resource *r)
> }
>
> /*
> - * RMID 0 is special and is always allocated. It's used for all
> - * tasks that are not monitored.
> - */
> - entry = __rmid_entry(0);
> + * These are used for rdtgroup_default control group, which will be
> + * setup later in rdtgroup_init().

This sentence I provided was intended to just replace two sentences, not the
entire paragraph you had. Note that I explicitly stated "change last two
sentences". Without the original text the above "These" is not clear.
If you just want to copy&paste here is the entire intended comment:

RESCTRL_RESERVED_CLOSID and RESCTRL_RESERVED_RMID are special and
are always allocated. These are used for the rdtgroup_default
control group, which will be setup later in rdtgroup_init().

Reinette