Re: [PATCH 02/41] rxrpc: Fix two connection reaping bugs

[Jeffrey E Altman]

On 11/9/2023 10:39 AM, David Howells wrote:
> Fix two connection reaping bugs:
>
>   (1) rxrpc_connection_expiry is in units of seconds, so
>       rxrpc_disconnect_call() needs to multiply it by HZ when adding it to
>       jiffies.
>
>   (2) rxrpc_client_conn_reap_timeout() should set RXRPC_CLIENT_REAP_TIMER if
>       local->kill_all_client_conns is clear, not if it is set (in which case
>       we don't need the timer).  Without this, old client connections don't
>       get cleaned up until the local endpoint is cleaned up.
>
> Fixes: 5040011d073d ("rxrpc: Make the local endpoint hold a ref on a connected call")
> Fixes: 0d6bf319bc5a ("rxrpc: Move the client conn cache management to the I/O thread")
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> cc: Marc Dionne <marc.dionne@xxxxxxxxxxxx>
> cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> cc: Paolo Abeni <pabeni@xxxxxxxxxx>
> cc: netdev@xxxxxxxxxxxxxxx
> cc: linux-afs@xxxxxxxxxxxxxxxxxxx
> ---
Reviewed-by: Jeffrey Altman <jaltman@xxxxxxxxxxxx>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature