Re: [PATCH 4/4] dt-bindings: hwmon: Add Amphenol ChipCap 2

[Guenter Roeck]

On 11/9/23 00:41, Krzysztof Kozlowski wrote:
> On 08/11/2023 13:44, Javier Carrasco wrote:
>
> > > > +properties:
> > > > +  compatible:
> > > > +    enum:
> > > > +      - amphenol,cc2dxx
> > > > +      - amphenol,cc2dxxs
> > >
> > > What does xx stand for? Wildcard? I do not see cc2dxx in part numbers.
> > > We expect specific compatibles, not generic. What are the differences
> > > between all parts?
> > There are two device families: cc2dxx and cc2dxxs, where xx indicates
> > the voltage and the accuracy. That does not change how the devices works
> > and it is not relevant for the driver. The 's' indicates that it is a
> > sleep device, and that modifies how it works.
> > I listed the supported part numbers in the hwmon documentation, where
> > they are also divided into these two families.
>
> If the number of devices is relatively small, list them all. Otherwise
> choose one device model and use it. No family models. No wildcards.

Agreed. There is no guarantee that CC2D[00..99][X] will be the same
devices.

Guenter