Re: [PATCH] MM: shmem: Remove code sytle warnings
From: kernel test robot
Date: Thu Nov 09 2023 - 08:26:55 EST
Hi Omkar,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master next-20231109]
[cannot apply to v6.6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Omkar-Wagle/MM-shmem-Remove-code-sytle-warnings/20231109-163742
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20231109062228.10227-1-ov.wagle%40gmail.com
patch subject: [PATCH] MM: shmem: Remove code sytle warnings
config: mips-allnoconfig (https://download.01.org/0day-ci/archive/20231109/202311092136.KQoibaVV-lkp@xxxxxxxxx/config)
compiler: mips-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231109/202311092136.KQoibaVV-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311092136.KQoibaVV-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
mm/shmem.c: In function 'shmem_fill_super':
>> mm/shmem.c:4310:47: error: macro "max_t" requires 3 arguments, but only 2 given
4310 | L1_CACHE_BYTES), GFP_KERNEL);
| ^
In file included from include/linux/kernel.h:28,
from include/linux/cpumask.h:10,
from arch/mips/include/asm/processor.h:15,
from arch/mips/include/asm/thread_info.h:16,
from include/linux/thread_info.h:60,
from include/asm-generic/preempt.h:5,
from ./arch/mips/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:79,
from include/linux/spinlock.h:56,
from include/linux/wait.h:9,
from include/linux/wait_bit.h:8,
from include/linux/fs.h:6,
from mm/shmem.c:24:
include/linux/minmax.h:169: note: macro "max_t" defined here
169 | #define max_t(type, x, y) __careful_cmp(max, (type)(x), (type)(y))
|
>> mm/shmem.c:4309:26: error: 'max_t' undeclared (first use in this function); did you mean 'rmap_t'?
4309 | sbinfo = kzalloc(max_t((int)sizeof(struct shmem_sb_info),
| ^~~~~
| rmap_t
mm/shmem.c:4309:26: note: each undeclared identifier is reported only once for each function it appears in
vim +/max_t +4310 mm/shmem.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 4300
f32356261d44d5 David Howells 2019-03-25 4301 static int shmem_fill_super(struct super_block *sb, struct fs_context *fc)
^1da177e4c3f41 Linus Torvalds 2005-04-16 4302 {
f32356261d44d5 David Howells 2019-03-25 4303 struct shmem_options *ctx = fc->fs_private;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4304 struct inode *inode;
0edd73b33426df Hugh Dickins 2005-06-21 4305 struct shmem_sb_info *sbinfo;
71480663b751de Carlos Maiolino 2023-07-25 4306 int error = -ENOMEM;
680d794babebc7 Andrew Morton 2008-02-08 4307
680d794babebc7 Andrew Morton 2008-02-08 4308 /* Round up to L1_CACHE_BYTES to resist false sharing */
1c6e8dc111cb86 Omkar Wagle 2023-11-08 @4309 sbinfo = kzalloc(max_t((int)sizeof(struct shmem_sb_info),
680d794babebc7 Andrew Morton 2008-02-08 @4310 L1_CACHE_BYTES), GFP_KERNEL);
680d794babebc7 Andrew Morton 2008-02-08 4311 if (!sbinfo)
71480663b751de Carlos Maiolino 2023-07-25 4312 return error;
680d794babebc7 Andrew Morton 2008-02-08 4313
680d794babebc7 Andrew Morton 2008-02-08 4314 sb->s_fs_info = sbinfo;
^1da177e4c3f41 Linus Torvalds 2005-04-16 4315
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki