Re: [PATCH] serial: uartlite: Use dynamic allocation for major number

From: Greg KH
Date: Thu Nov 09 2023 - 08:20:37 EST


On Thu, Nov 09, 2023 at 06:06:40PM +0530, Manikanta Guntupalli wrote:
> Device number 204 has a range of minors on major number.
> uart_register_driver is failing due to lack of minor numbers
> when more number of uart ports used.

So you need more than the 4 allocated to you?

> So, use dynamic allocation
> for major number to avoid minor number limitation on 204 major
> number.
>
> https://docs.kernel.org/arch/arm/sa1100/serial_uart.html

What does this break by doing this?

Also, you forgot to update the documentation :(

And how was this tested? What about older systems with static device
nodes, are you sure none are out there for this old hardware anymore?

thanks,

greg k-h