On 09/11/2023 09:06, zhangqing wrote:
在 2023/11/9 15:29, Conor Dooley 写道:Then you are not allowed to change it. It's part of ABI.
On Thu, Nov 09, 2023 at 02:27:38PM +0800, zhangqing wrote:I don't think it's more appropriate to move to clk-rkxxx.c.
Hi:Then delete it from the header and move it to clk-rkxxx.c
在 2023/11/8 20:01, Conor Dooley 写道:
On Wed, Nov 08, 2023 at 02:18:21PM +0800, Elaine Zhang wrote:The new ID is to solve the niu clock dependency problem(Used in PATCH V5
export PCLK_VO1GRF for DT.This definition is part of the ABI, if it is safe to change it, then it
Signed-off-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx>
---
include/dt-bindings/clock/rockchip,rk3588-cru.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
index 5790b1391201..50ba72980190 100644
--- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
+++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
@@ -733,8 +733,9 @@
#define ACLK_AV1_PRE 718
#define PCLK_AV1_PRE 719
#define HCLK_SDIO_PRE 720
+#define PCLK_VO1GRF 721
-#define CLK_NR_CLKS (HCLK_SDIO_PRE + 1)
+#define CLK_NR_CLKS (PCLK_VO1GRF + 1)
is safe to delete it.
4/4).This new ID will also be used in DTS in the future.
CLK_NR_CLKS represents the number of clocks used by the
drivers/clk/rockchip/clk-rkxxx.c. It is safe to modify it, but cannot delete
it.
Because if there are new requirements later, and add new clk id, it is
not in the same file, maybe forget to modify CLK_NR_CLKS.
--
Best regards,
Krzysztof