Re: [PATCH] iphase: Adding a null pointer check

From: Jakub Kicinski
Date: Wed Nov 08 2023 - 21:40:54 EST


On Tue, 7 Nov 2023 15:36:00 +0300 Andrey Shumilin wrote:
> The pointer <dev->desc_tbl[i].iavcc> is dereferenced on line 195.
> Further in the code, it is checked for null on line 204.
> It is proposed to add a check before dereferencing the pointer.

How do you know this is the right way to address the problem.
Much easier to debug a crash than misbehaving driver.

This is ancient code, leave it be.
--
pw-bot: reject
pv-bot: nit