RE: [PATCH 10/13] scsi: fnic: Add support for multiqueue (MQ) in fnic_main.c

From: Karan Tilak Kumar (kartilak)
Date: Wed Nov 08 2023 - 21:21:27 EST


On Wednesday, November 8, 2023 5:57 AM, John Garry <john.g.garry@xxxxxxxxxx> wrote:
> Please be aware of comment on nr_hw_queues in scsi_host.h - maybe it is relevant to this adapter:
>
> "the total queue depth per host is nr_hw_queues * can_queue"

Thanks John.

> Also, since you seem to be using blk_mq_unique_tag() as the per-IO tag, I assume that you don't need to set shost.host_tagset (for that reason).

Yes, that's correct.

> > +void fnic_mq_map_queues_cpus(struct Scsi_Host *host)
>
> This function looks to do effectively the same as blk_mq_pci_map_queues(), right?

Yes, it looks like it is accomplishing the same goal. Thanks for this information.
I'll experiment with this function on my setup and make suitable modifications in v3, if successful.

Regards,
Karan