Re: [PATCH] perf test: Add option to change objdump binary

From: Arnaldo Carvalho de Melo
Date: Wed Nov 08 2023 - 15:48:57 EST


Em Tue, Nov 07, 2023 at 09:37:32AM +0000, James Clark escreveu:
>
>
> On 03/11/2023 15:41, Ian Rogers wrote:
> > On Fri, Nov 3, 2023 at 4:35 AM James Clark <james.clark@xxxxxxx> wrote:
> > >
> > > All of the other Perf subcommands that use objdump have an option to
> > > specify the binary, so add the same option to perf test.
> > >
> > > This is useful if you have built the kernel with a different toolchain
> > > to the system one, where the system objdump may fail to disassemble
> > > vmlinux.
> > >
> > > Now this can be fixed with something like this:
> > >
> > > $ perf test --objdump llvm-objdump "object code reading"
> > >
> > > Signed-off-by: James Clark <james.clark@xxxxxxx>
> >
> > There is also "perf config" for things like this.
> >
> > Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>
> >
> > Thanks,
> > Ian
>
> That seems a bit better for this use case so I added it in V2.

Have you posted it?

> Thanks for the review.
>
> James

--

- Arnaldo