Re: net: bcmasp: Use common error handling code in bcmasp_probe()

[Florian Fainelli]

On 11/7/23 10:48, Justin Chen wrote:
> On Mon, Nov 6, 2023 at 10:38 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
> > > > Add a jump target so that a bit of exception handling can be better
> > > > reused at the end of this function.
> > …
> > > > ---
> > > >   drivers/net/ethernet/broadcom/asp2/bcmasp.c | 10 ++++++----
> > > >   1 file changed, 6 insertions(+), 4 deletions(-)
> > >
> > > The diffstat proves otherwise.
> > > Please don't send such patches to networking.
> >
> > How does this feedback fit to a change possibility which was reviewed by
> > Wojciech Drewek yesterday?
> >
> > Regards,
> > Markus
>
> We are making the code harder to follow with these changes. Also
> adding more lines than removing. Don't think this patch is an
> improvement IMHO. NAK on my end.

Likewise, at the very least, why not have the remove_intfs label 
immediately above the of_put_exit one so then it just falls through, and 
then obviously update the return path to drop the reference count and 
return success?
--
Florian

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature