Re: [PATCH 03/10] ftrace: Remove the now superfluous sentinel elements from ctl_table array

From: Steven Rostedt
Date: Wed Nov 08 2023 - 11:27:28 EST


On Wed, 8 Nov 2023 19:29:49 +0900
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:

> On Tue, 07 Nov 2023 14:45:03 +0100
> Joel Granados via B4 Relay <devnull+j.granados.samsung.com@xxxxxxxxxx> wrote:
>
> > From: Joel Granados <j.granados@xxxxxxxxxxx>
> >
> > This commit comes at the tail end of a greater effort to remove the
> > empty elements at the end of the ctl_table arrays (sentinels) which
> > will reduce the overall build time size of the kernel and run time
> > memory bloat by ~64 bytes per sentinel (further information Link :
> > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@xxxxxxxxxxxxxxxxxxxxxx/)
> >
> > Remove sentinel elements from ftrace_sysctls and user_event_sysctls
> >
>
> Both looks good to me. (since register_sysctl_init() uses ARRAY_SIZE()
> macro to get the array size.)
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

Agreed.

Acked-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

-- Steve