Re: [PATCH v4 5/6] add listmount(2) syscall

From: Jonathan Corbet
Date: Wed Nov 08 2023 - 11:20:33 EST


Christian Brauner <brauner@xxxxxxxxxx> writes:

>> Why use struct __mount_arg (or struct mnt_id_req :) here rather than
>> just passing in the mount ID directly? You don't use the request_mask
>
> Please see Arnd's detailed summary here:
> https://lore.kernel.org/lkml/44631c05-6b8a-42dc-b37e-df6776baa5d4@xxxxxxxxxxxxxxxx

Ah, makes sense, I'd missed that.

Given this, though, it seems like maybe sys_listmount() should enforce
that req->request_mask==0 ?

Thanks,

jon