Re: [PATCH] ASoC: dt-bindings: use "soundwire" as controller's node name in examples

[Conor Dooley]

On Tue, Nov 07, 2023 at 11:16:10AM +0100, Krzysztof Kozlowski wrote:
> Soundwire Devicetree bindings expect the Soundwire controller device
> node to be named just "soundwire".  Correct examples, so the incorrect
> code will not be re-used.
> 
> Reported-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

FWIW, there are a few instances of "soundwire-controller" in qcom
devicetrees that you might also want to change.

> ---
>  Documentation/devicetree/bindings/sound/adi,max98363.yaml | 2 +-
>  Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml | 2 +-
>  Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/adi,max98363.yaml b/Documentation/devicetree/bindings/sound/adi,max98363.yaml
> index a844b63f3930..c388cda56011 100644
> --- a/Documentation/devicetree/bindings/sound/adi,max98363.yaml
> +++ b/Documentation/devicetree/bindings/sound/adi,max98363.yaml
> @@ -39,7 +39,7 @@ unevaluatedProperties: false
>  
>  examples:
>    - |
> -    soundwire-controller@3250000 {
> +    soundwire@3250000 {
>          #address-cells = <2>;
>          #size-cells = <0>;
>          reg = <0x3250000 0x2000>;
> diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml
> index ba572a7f4f3c..8e462cdf0018 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml
> @@ -52,7 +52,7 @@ examples:
>    - |
>      #include <dt-bindings/gpio/gpio.h>
>  
> -    soundwire-controller@3250000 {
> +    soundwire@3250000 {
>          #address-cells = <2>;
>          #size-cells = <0>;
>          reg = <0x3250000 0x2000>;
> diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml
> index e6723c9e312a..d717017b0fdb 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml
> @@ -48,7 +48,7 @@ examples:
>    - |
>      #include <dt-bindings/gpio/gpio.h>
>  
> -    soundwire-controller {
> +    soundwire {
>          #address-cells = <2>;
>          #size-cells = <0>;
>  
> -- 
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature