Re: [PATCH v5 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id

From: Krzysztof Kozlowski
Date: Wed Nov 08 2023 - 07:12:54 EST


On 08/11/2023 13:01, Conor Dooley wrote:
> On Wed, Nov 08, 2023 at 02:18:21PM +0800, Elaine Zhang wrote:
>> export PCLK_VO1GRF for DT.
>>
>> Signed-off-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx>
>> ---
>> include/dt-bindings/clock/rockchip,rk3588-cru.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
>> index 5790b1391201..50ba72980190 100644
>> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
>> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
>> @@ -733,8 +733,9 @@
>> #define ACLK_AV1_PRE 718
>> #define PCLK_AV1_PRE 719
>> #define HCLK_SDIO_PRE 720
>> +#define PCLK_VO1GRF 721
>>
>
>> -#define CLK_NR_CLKS (HCLK_SDIO_PRE + 1)
>> +#define CLK_NR_CLKS (PCLK_VO1GRF + 1)
>
> This definition is part of the ABI, if it is safe to change it, then it
> is safe to delete it.
>

+1
(and we already started doing this for some platforms)

Best regards,
Krzysztof