Re: [PATCH v2] drivers/net/ppp: use standard array-copy-function

From: patchwork-bot+netdevbpf
Date: Wed Nov 08 2023 - 04:50:28 EST


Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@xxxxxxxxxxxxx>:

On Mon, 6 Nov 2023 10:16:00 +0100 you wrote:
> In ppp_generic.c, memdup_user() is utilized to copy a userspace array.
> This is done without an overflow-check, which is, however, not critical
> because the multiplicands are an unsigned short and struct sock_filter,
> which is currently of size 8.
>
> Regardless, string.h now provides memdup_array_user(), a wrapper for
> copying userspace arrays in a standardized manner, which has the
> advantage of making it more obvious to the reader that an array is being
> copied.
> The wrapper additionally performs an obligatory overflow check, saving
> the reader the effort of analyzing the potential for overflow, and
> making the code a bit more robust in case of future changes to the
> multiplicands len * size.
>
> [...]

Here is the summary with links:
- [v2] drivers/net/ppp: use standard array-copy-function
https://git.kernel.org/netdev/net/c/caf3100810f4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html