Re: [PATCH v2 1/7] scsi: ufs: host: Rename structure ufs_dev_params to ufs_host_params

[Can Guo]

Hi Bart,

On 11/8/2023 4:56 AM, Bart Van Assche wrote:
> On 11/6/23 20:46, Can Guo wrote:
> >   /**
> > - * ufshcd_get_pwr_dev_param - get finally agreed attributes for
> > + * ufshcd_negotiate_pwr_param - get finally agreed attributes for
> >    *                            power mode change
>
> Since you are renaming the function, please also change the description
> of the function into something more meaningful, e.g. "find power mode
> settings that are supported by both the controller and the device".
Sure, will do.
> > - * @pltfrm_param: pointer to platform parameters
> > + * @host_param: pointer to platform parameters
>
> Please make sure that the argument name and argument description are in
> sync.
Sure.
> Thanks,
>
> Bart.


Thanks,

Can Guo.