Re: [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning

From: Bagas Sanjaya
Date: Tue Nov 07 2023 - 18:59:01 EST


On Tue, Nov 07, 2023 at 11:28:30AM -0500, Hunter Chasens wrote:
> Resolves Sphinx unexpected indentation warning when compiling
> documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
> a literal block to keep vertical formatting of the
> example power state list.
>
> Signed-off-by: Hunter Chasens <hunter.chasens18@xxxxxxx>

Nit: Whenever a reviewer has offered a Reviewed-by: or Acked-by: trailer,
you should include it in the next reroll unless there is substantial changes
in the reroll.

> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 517b9fb4624c..576202bf64f3 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -989,12 +989,13 @@ static ssize_t amdgpu_get_pp_features(struct device *dev,
> * Reading back the files will show you the available power levels within
> * the power state and the clock information for those levels. If deep sleep is
> * applied to a clock, the level will be denoted by a special level 'S:'
> - * E.g.,
> - * S: 19Mhz *
> - * 0: 615Mhz
> - * 1: 800Mhz
> - * 2: 888Mhz
> - * 3: 1000Mhz
> + * E.g., ::
> + *
> + * S: 19Mhz *
> + * 0: 615Mhz
> + * 1: 800Mhz
> + * 2: 888Mhz
> + * 3: 1000Mhz
> *
> *
> * To manually adjust these states, first select manual using

Anyway, LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx>

--
An old man doll... just what I always wanted! - Clara

Attachment: signature.asc
Description: PGP signature