Re: [PATCH RESEND v3 4/5] clk: qcom: Use HW_CTRL_TRIGGER flag to switch video GDSC to HW mode

[Konrad Dybcio]

On 11/7/23 14:05, Bryan O'Donoghue wrote:
> On 01/11/2023 09:04, Abel Vesa wrote:
> > From: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx>
> >
> > The current HW_CTRL flag switches the video GDSC to HW control mode as
> > part of GDSC enable itself, instead of that use HW_CTRL_TRIGGER flag to
> > give consumer drivers more control and switch the GDSC mode as and when
> > required.
> >
> > HW_CTRL_TRIGGER flag allows consumer drivers to switch the video GDSC to
> > HW/SW control modes at runtime using dev_pm_genpd_set_hwmode API.
> >
> > Signed-off-by: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx>
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > ---
> >   drivers/clk/qcom/videocc-sc7180.c | 2 +-
> >   drivers/clk/qcom/videocc-sc7280.c | 2 +-
> >   drivers/clk/qcom/videocc-sdm845.c | 4 ++--
> >   drivers/clk/qcom/videocc-sm8250.c | 4 ++--
> >   drivers/clk/qcom/videocc-sm8550.c | 4 ++--
> >   5 files changed, 8 insertions(+), 8 deletions(-)
>
> So.
>
> I'm assuming the rest of this series works however for sc8250 at least this is a NAK, breaks venus on rb5.
Are you saying that applying this patch alone causes the attached crash?

Konrad