Re: [PATCH 10/10] bpf: Remove the now superfluous sentinel elements from ctl_table array

From: Andrii Nakryiko
Date: Tue Nov 07 2023 - 13:15:57 EST


On Tue, Nov 7, 2023 at 5:45 AM Joel Granados via B4 Relay
<devnull+j.granados.samsung.com@xxxxxxxxxx> wrote:
>
> From: Joel Granados <j.granados@xxxxxxxxxxx>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@xxxxxxxxxxxxxxxxxxxxxx/)
>
> Remove sentinel element from bpf_syscall_table.
>
> Signed-off-by: Joel Granados <j.granados@xxxxxxxxxxx>
> ---
> kernel/bpf/syscall.c | 1 -
> 1 file changed, 1 deletion(-)
>

LGTM.

Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx>

> diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
> index eb01c31ed591..1cb5b852b4e7 100644
> --- a/kernel/bpf/syscall.c
> +++ b/kernel/bpf/syscall.c
> @@ -5679,7 +5679,6 @@ static struct ctl_table bpf_syscall_table[] = {
> .mode = 0644,
> .proc_handler = bpf_stats_handler,
> },
> - { }
> };
>
> static int __init bpf_syscall_sysctl_init(void)
>
> --
> 2.30.2
>